Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

5634 unit testing #5658

Merged
merged 11 commits into from
Mar 18, 2019
Merged

5634 unit testing #5658

merged 11 commits into from
Mar 18, 2019

Conversation

rschlaefli
Copy link
Contributor

This PR adds some initial unit tests to the following classes/methods:

  • FileMetadata.getFileDateToDisplay
  • DataAccess.createNewStorageIO (partial)
  • FileSizeChecker.testIsAllowedFileSize

I also added and used the testing dependency on junit.jupiter.params as described in #5657.

Related Issues

Pull Request Checklist

  • Unit [tests][] completed
  • Integration [tests][]: None
  • Deployment requirements, [SQL updates][], [Solr updates][], etc.: None
  • [Documentation][docs] completed
  • Merged latest from "develop" [branch][] and resolved conflicts

@coveralls
Copy link

coveralls commented Mar 16, 2019 •
edited

Coverage Status

Coverage increased (+0.2%) to 17.735% when pulling 15e209c on rschlaefli:5634-unit-testing into 9439313 on IQSS:develop.

@matthew-a-dunlap matthew-a-dunlap self-assigned this Mar 18, 2019
matthew-a-dunlap
matthew-a-dunlap suggested changes Mar 18, 2019
View reviewed changes
Copy link
Contributor

@matthew-a-dunlap matthew-a-dunlap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the code coverage! Overall things look good but I have a few minor requests

src/test/java/edu/harvard/iq/dataverse/dataaccess/DataAccessTest.java Outdated Show resolved Hide resolved
src/test/java/edu/harvard/iq/dataverse/dataaccess/DataAccessTest.java Outdated Show resolved Hide resolved
src/test/java/edu/harvard/iq/dataverse/datasetutility/FileSizeCheckerTest.java Outdated Show resolved Hide resolved
src/test/java/edu/harvard/iq/dataverse/datasetutility/FileSizeCheckerTest.java Outdated Show resolved Hide resolved
@rschlaefli
Copy link
Contributor Author

Hi @matthew-a-dunlap! Thanks for the comments, I have resolved them in my last two commits :)

matthew-a-dunlap
matthew-a-dunlap approved these changes Mar 18, 2019
View reviewed changes
Copy link
Contributor

@matthew-a-dunlap matthew-a-dunlap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for the quick changes!

@kcondon kcondon merged commit 48c1b50 into IQSS:develop Mar 18, 2019
@kcondon kcondon requested review from kcondon and removed request for kcondon March 18, 2019 23:04
@kcondon kcondon self-assigned this Mar 18, 2019
@djbrooke djbrooke added this to the 4.12 milestone Mar 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthew-a-dunlap matthew-a-dunlap matthew-a-dunlap approved these changes

Assignees

@kcondon kcondon

Labels
None yet
Projects
None yet
Milestone
4.12
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@rschlaefli @coveralls @matthew-a-dunlap @pdurbin @kcondon @djbrooke